-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix getBackToParam #30144
Conversation
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-10-22.at.21.36.55.mp4Mobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well and code lgtm except one nab
@@ -7,12 +7,13 @@ import CONST from './CONST'; | |||
|
|||
/** | |||
* This is a file containing constants for all of the routes we want to be able to go to | |||
* Returns an encoded URI component for the backTo param which can be added to the end of URLs | |||
* Returns the URL with an encoded URI component for the backTo param which can be added to the end of URLs | |||
* @param backTo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @param backTo | |
* @param url | |
* @param backTo |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix getBackToParam (cherry picked from commit a8841fb)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.88-9 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀
|
Thanks for fixing this and sorry I wasn't able to help with it! |
cc @thienlnam
Details
Fixes the url concatenation with
getBackToParam
Fixed Issues
$ #30128
Tests
Settings > Profile > Personal details > Address > Country
Hmm it's not here
pageOffline tests
N.A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
chrome.mov
iOS: Native
ios.mov
iOS: mWeb Safari
safari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov